Add Unit Test for OSS, OBS and GCS #17985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alluxio-bot, merge this please |
jja725
reviewed
Sep 20, 2023
| } catch (ServiceException e) { | ||
| LOG.error("Failed to create GCSUnderFileSystem.", e); | ||
| throw Throwables.propagate(e); | ||
| if (checkGCSCredentials(conf)) { |
There was a problem hiding this comment.
this is not correct, we can't check whether this is set or not since only v1 would set access key and if we use v2 credential we would not be able to create ufs @JiamingMai @zhezhidashi
There was a problem hiding this comment.
OK, I will fix this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add Unit Test for OSS, OBS and GCS
Why are the changes needed?
Unit test is important for improving functions of Alluxio.
Does this PR introduce any user facing changes?
No