Fix Unrecognized error #18527
Merged
Fix Unrecognized error #18527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jja725
force-pushed
the
fix-scheduler-type
branch
from
ff8cde7 to
43f89bb
Compare
lucyge2022
reviewed
Feb 23, 2024
| @@ -62,7 +62,8 @@ public static int compareTierNames(String a, String b) { | |||
| public static void checkMasterClientService(AlluxioConfiguration alluxioConf) throws IOException { | |||
| MembershipType membershipType = alluxioConf | |||
| .getEnum(PropertyKey.WORKER_MEMBERSHIP_MANAGER_TYPE, MembershipType.class); | |||
| if (membershipType == MembershipType.ETCD || membershipType == MembershipType.STATIC) { | |||
| if (membershipType == MembershipType.ETCD || membershipType == MembershipType.STATIC | |||
| || membershipType == MembershipType.SERVICE_REGISTRY) { | |||
There was a problem hiding this comment.
use membershipType != MembershipType.MASTER instead?
and try to fix test
jja725
force-pushed
the
fix-scheduler-type
branch
from
43f89bb to
ba559bf
Compare
|
alluxio-bot, merge this please |
|
merge failed: |
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Unrecognized error
What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including