Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require outdated wasm-bindgen feature from uuid #34

Closed
wants to merge 1 commit into from

Conversation

Twey
Copy link

@Twey Twey commented Apr 2, 2024

The uuid package hasn't had the feature wasm-bindgen since uuid-rs/uuid#536, in which it was renamed to js, but using it continues to work on wasm32-unknown-unknown because it accidentally activates the optional wasm-bindgen dependency that is only available on that platform.

@Twey Twey requested a review from Alorel as a code owner April 2, 2024 17:13
@benthecarman
Copy link

it looks like this dep is only used in tests, could be moved to dev deps

@ptdecker
Copy link

ptdecker commented Jul 8, 2024

Hello! Any update on when this fix will be merged and released? This is a blocking issue for a global upgrade we are working to move to uuid v1.9.1:

from our relevant Cargo.toml

[target.'cfg(target_arch = "wasm32")'.dependencies]
indexed_db_futures = { version = "0.4.1" }

build error:

    ... required by package `indexed_db_futures v0.4.1`
    ... which satisfies dependency `indexed_db_futures = "^0.4.1"` of package `securikey-lib v2.1.0 (/Users/ptdecker/PycharmProjects/vHSM/securikey-lib)`
versions that meet the requirements `^1.5.0` are: 1.9.1, 1.9.0, 1.8.0, 1.7.0, 1.6.1, 1.6.0, 1.5.0

the package `indexed_db_futures` depends on `uuid`, with features: `wasm-bindgen` but `uuid` does not have these features.
 It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.


all possible versions conflict with previously selected packages.

  previously selected package `uuid v1.9.1`
    ... which satisfies dependency `uuid = "^1.9.1"` of package `securikey-lib v2.1.0 (/Users/ptdecker/PycharmProjects/vHSM/securikey-lib)`

failed to select a version for `uuid` which could resolve this conflict

Alorel pushed a commit to TiemenSch/rust-indexed-db that referenced this pull request Jul 26, 2024
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>

Closes Alorel#34
Alorel pushed a commit to TiemenSch/rust-indexed-db that referenced this pull request Jul 26, 2024
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>

Closes Alorel#34, Alorel#35
@Alorel Alorel closed this in d1c47c5 Jul 26, 2024
@Alorel
Copy link
Owner

Alorel commented Jul 26, 2024

Fixed with 0.4.2, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants