Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux (fedora) compilation issues #594

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Conversation

codinghipster
Copy link

I can't compile on Fedora 24, I think this is the source of the issue

@thias
Copy link

thias commented Jul 31, 2016

Thanks a lot! I can confirm that this fixes compilation on Fedora 24 for me too. I have now updated my packages at http://dl.marmotte.net/rpms/fedora/24/x86_64/ and spec files at https://github.com/thias/retroarch-fedora/.

@theist
Copy link

theist commented Jan 9, 2017

This PR also fixed the same compilation error described in #591 on an ubuntu GNU/Linux 16.10

@grantbacon
Copy link

This also fixes my compilation errors on Debian Stretch

@robindegen
Copy link

This also fixed the problem for me on ubuntu 17.04. Why wasn't this or a similar fix merged?

@fizzlebert
Copy link

Why hasn't this PR been accepted it fixes broken code on the master branch?

@robindegen
Copy link

@danieloconell Because apparently they moved all development to RetroPi/EmulationStation and it's probably maybe integrated there. It's just not very clear that they've done so.

@kpksmiley
Copy link

What code do you use to get the files? I keep getting an error saying unable to locate package, when I used:
sudo apt-get install http://dl/marmotte.net/rpms/fedora/24/x86_64

Copy link

@kasi09 kasi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job !!
Work on Debian/Stretch Rock64.

@codinghipster
Copy link
Author

@Aloshi are you accepting PRs, and is this still the most active repo?

@robindegen
Copy link

@codinghipster It's not. Look at the last commit dates. They are all from a few years ago. The up-to-date repo is at RetroPi/EmulationStation as I mentioned above.

@theist
Copy link

theist commented Mar 9, 2018

@codinghipster seems that this repo is unmantained and the current one is https://github.com/RetroPie/EmulationStation

@codinghipster
Copy link
Author

@Aloshi's website and repo are still the first results on google when searching for emulation station, it would be nice to see this repo and /or website updated

@robindegen
Copy link

@codinghipster Yes, but apparently he's disappeared and doesn't really update anything anymore. So the new project can't update this stuff.

gillg pushed a commit to gillg/recalbox-emulationstation that referenced this pull request Apr 10, 2018
@Aloshi Aloshi merged commit 9cc42ad into Aloshi:master Aug 26, 2018
@Aloshi
Copy link
Owner

Aloshi commented Aug 26, 2018

Better late than never, I suppose

@lewsidius
Copy link

Really noob question how do you implement this fix? Do I edit or add script somewhere? Getting better at it and mainly work on retropie. sorry still learning

bloodyreaper added a commit to bloodyreaper/EmulationStation that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants