Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target Spin #202

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Target Spin #202

merged 5 commits into from
Mar 25, 2024

Conversation

ljgreenhill
Copy link
Member

@ljgreenhill ljgreenhill commented Mar 25, 2024 •
edited
Loading

Target Spin

Summary of changes

  • Pass resolution into target spin SFR value
  • SFR fields cannot be initialized based on other SFR fields

Deemocean
Deemocean approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Deemocean Deemocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ljgreenhill ljgreenhill merged commit ad019f1 into main Mar 25, 2024
4 checks passed
@ljgreenhill ljgreenhill deleted the target_spin_fix branch March 25, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deemocean Deemocean Deemocean approved these changes

@dhacks541 dhacks541 Awaiting requested review from dhacks541

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljgreenhill @Deemocean