EIP5169 files from IPFS are intrinsically signed #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for alpha-wallet-android:
|
Codecov ReportBase: 7.25% // Head: 7.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2792 +/- ##
===========================================
+ Coverage 7.25% 7.31% +0.05%
- Complexity 759 765 +6
===========================================
Files 568 568
Lines 40415 40462 +47
Branches 4120 4126 +6
===========================================
+ Hits 2932 2958 +26
- Misses 37232 37252 +20
- Partials 251 252 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
seabornlee
approved these changes
Aug 31, 2022
seabornlee
added a commit
that referenced
this pull request
Aug 31, 2022
This reverts commit 5746c1e.
|
Sorry, didn't aware the WIP label. |
seabornlee
pushed a commit
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2785
Scripts sourced from the
scriptURI()method, which are located on IPFS are intrinsically signed because the contract owner has set the method return and IPFS hashing mechanism means the file is immutable.TODO: Integration Test