-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPFS connection point #2920
Conversation
Pull reviewers statsStats of the last 30 days for alpha-wallet-android:
|
Codecov ReportBase: 7.51% // Head: 7.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2920 +/- ##
===========================================
+ Coverage 7.51% 7.57% +0.06%
- Complexity 810 833 +23
===========================================
Files 608 611 +3
Lines 41792 41827 +35
Branches 4234 4241 +7
===========================================
+ Hits 3139 3167 +28
+ Misses 38393 38388 -5
- Partials 260 272 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* Collect code check result * Fix path * Ignore error * Comment PR * Don't print color * Fix command
app/src/main/java/com/alphawallet/app/entity/tokenscript/TestScript.java: 1 errors found app/src/main/java/com/alphawallet/app/service/AssetDefinitionService.java: 6 errors found app/src/main/java/com/alphawallet/app/service/TransactionsNetworkClient.java: 5 errors found app/src/main/java/com/alphawallet/app/web3j/ens/NameHash.java: 1 errors found |
app/src/main/java/com/alphawallet/app/service/AssetDefinitionService.java: 6 errors found app/src/main/java/com/alphawallet/app/service/TransactionsNetworkClient.java: 5 errors found app/src/main/java/com/alphawallet/app/web3j/ens/NameHash.java: 1 errors found |
app/src/main/java/com/alphawallet/app/service/TransactionsNetworkClient.java: 2 errors found |
* Shift to using type interface for IPFSService to make it possible to implement IO-free unit tests * Update IPFS usage and add unit testing for new service. * Fix certificate test * Updates as suggested
* Shift to using type interface for IPFSService to make it possible to implement IO-free unit tests * Update IPFS usage and add unit testing for new service. * Fix certificate test * Updates as suggested
This PR adds a service for resolving IPFS more reliably than previously - if there's a socket timeout it switches to an alternate IPFS provider.
It also provides a more reliable IPFS resolve as there are fewer paths.
Also