-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WC v1] Fixed signTypedData_v4 routing #3141
Conversation
Pull reviewers statsStats of the last 30 days for alpha-wallet-android:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3141 +/- ##
========================================
Coverage 7.67% 7.68%
Complexity 902 902
========================================
Files 653 653
Lines 44173 44176 +3
Branches 4454 4455 +1
========================================
+ Hits 3392 3394 +2
- Misses 40493 40494 +1
Partials 288 288
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need a route for eth_signTypedData_v3 ?
* Fixed signTypedData_v4 routing * Add signTypedData_v3 to parser
eth_signTypedData_v4
messages are not routed properly because of a missing enum, hence the signing dialog does not appear.