Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a build so that the artifacts (jars for Android, frameworks for iOS) and their dependencies can be included in another project #5234

Closed
2 tasks
hboon opened this issue Aug 29, 2022 · 10 comments · Fixed by #5238, #5246 or #5301
Assignees

Comments

@hboon
Copy link
Member

hboon commented Aug 29, 2022

  • We can keep the UI, but not spin it up
  • Make a dummy function in the code that signs a message
  • Create a new skeleton driver project that uses this AlphaWallet project that includes something like this pseudocode:
import SDK
let wallet = SDK.Wallet("hardcoded seed phrase")
let result = wallet.signPersonal("some message")
let address = SDK.ecrecover(result)
print(wallet.address == address)

Goals

  • Check feasibility
  • Check constraints (including usage of dependencies, operating system requirements, build options)
@oa-s
Copy link
Contributor

oa-s commented Aug 29, 2022

  • - group types extension in model defition files
  • - group models in related folders, (scattered on to many files)
  • - group logic in (core) folder
  • - replace some definision to avoid adding additional dependencies, especially for (wallet connect, firebase) as modules added with spm.
  • - move logic to AlphaWallet pod

@oa-s
Copy link
Contributor

oa-s commented Aug 29, 2022

out of steps above:
we are going to have the next structure:
module like token, transactions, activities, settings, are going to stay in root project, as well as view model, and view definitions, and the rest of code will be located in pod

@oa-s
Copy link
Contributor

oa-s commented Aug 30, 2022

@hboon there is an issue with applying localization for enum cases or some description that were extracted to logic pod, as well as image usage, how to act in this case? how we could apply r.swift for pod, and where all of these resources should be?

@hboon
Copy link
Member Author

hboon commented Aug 31, 2022

@hboon there is an issue with applying localization for enum cases or some description that were extracted to logic pod, as well as image usage, how to act in this case? how we could apply r.swift for pod, and where all of these resources should be?

Can we cope with adding them in class/type extensions in the main app? That'll be the easiest to manage localisations

@oa-s
Copy link
Contributor

oa-s commented Aug 31, 2022

Can we cope with adding them in class/type extensions in the main app? That'll be the easiest to manage localisations

That is exactly what i am working on ;)

oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Aug 31, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Aug 31, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Aug 31, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Aug 31, 2022
oa-s added a commit that referenced this issue Aug 31, 2022
Group logic components in core folder #5234
@oa-s oa-s reopened this Aug 31, 2022
@oa-s oa-s closed this as completed in #5246 Sep 2, 2022
oa-s added a commit that referenced this issue Sep 2, 2022
remove dependency from resources #5234
@hboon
Copy link
Member Author

hboon commented Sep 2, 2022

@oa-s is this issue closed yet? Only preparation work is done, right?

@hboon hboon reopened this Sep 2, 2022
@oa-s
Copy link
Contributor

oa-s commented Sep 3, 2022

looks like it could be closed

@hboon
Copy link
Member Author

hboon commented Sep 4, 2022

Also need this :) — #5234 (comment)

@hboon
Copy link
Member Author

hboon commented Sep 5, 2022

Forgot to assign earlier :P

@oa-s
Copy link
Contributor

oa-s commented Sep 5, 2022

Also need this :) — #5234 (comment)

@hboon could you please explain, not so clear

oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Sep 8, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Sep 8, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Sep 9, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Sep 9, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Sep 9, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Sep 9, 2022
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Sep 9, 2022
@oa-s oa-s closed this as completed in #5301 Sep 9, 2022
oa-s added a commit that referenced this issue Sep 9, 2022
move pod specs for `foundation, ens, core, opensea, goBack` libraries #5234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment