Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: About Us #441

Merged
merged 7 commits into from
Aug 9, 2024
Merged

feat: About Us #441

merged 7 commits into from
Aug 9, 2024

Conversation

v-almonacid
Copy link
Contributor

image

isAuthenticated,
setTutFocusElemRef,
profile,
}) => {
const [toggleState, setToggleState] = useState(false);
const [toggleTutorialState, setToggleTutorialState] = useState(false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some unrelated renaming

ModalHeader,
ModalBody,
ModalTitle,
ModalFooter,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we forgot to export these

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because Modals were placed here packages/ui-kit/src/components/modal
Screenshot 2024-08-08 at 21 33 46

@v-almonacid v-almonacid marked this pull request as ready for review August 8, 2024 19:22
Copy link
Member

@elcharitas elcharitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, lgtm

Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good added a few comments.

ModalHeader,
ModalBody,
ModalTitle,
ModalFooter,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because Modals were placed here packages/ui-kit/src/components/modal
Screenshot 2024-08-08 at 21 33 46

@v-almonacid v-almonacid marked this pull request as draft August 9, 2024 14:53
@v-almonacid v-almonacid marked this pull request as ready for review August 9, 2024 14:53
@v-almonacid v-almonacid merged commit ca39a00 into dev Aug 9, 2024
1 check passed
@v-almonacid v-almonacid deleted the ALPHA-5625 branch August 9, 2024 15:00
@v-almonacid v-almonacid restored the ALPHA-5625 branch August 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants