Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(superfeed): search filters doesn't add pills to searchbar #460

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix(superfeed): search filters doesn't add pills to searchbar #460

merged 4 commits into from
Oct 29, 2024

Conversation

elcharitas
Copy link
Member

The issue was as a result of a cached memo dep and nothing else.

This PR only enforces the checks

@elcharitas elcharitas marked this pull request as ready for review October 23, 2024 07:34
Xavier-Charles
Xavier-Charles reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should but this in an if statement so that basic checks pass.

 if (keywordResults !== undefined && keywordResults?.[ESupportedFilters.Coins]) {
   groupedKeywordsAsOptions(keywordResults)
 }

@elcharitas elcharitas marked this pull request as draft October 29, 2024 05:39
@elcharitas elcharitas marked this pull request as ready for review October 29, 2024 05:39
Xavier-Charles
Xavier-Charles approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elcharitas elcharitas merged commit 531f53f into dev Oct 29, 2024
1 check passed
@elcharitas elcharitas deleted the fix/discord-like branch October 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xavier-Charles Xavier-Charles Xavier-Charles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elcharitas @Xavier-Charles