-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISS-115: Reorganising demo buttons into tabs #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Now that I've had a chance to run the actual demo, I should note that a couple of the file read/write tests dump some error output to the console. They still pass, so it's not a big deal, but if there's an easy way to get rid of that you might consider it.
ERROR!!! :: Failed to open file: testing/this_file_does_not_exist.txt for buffer_load()
ERROR!!! :: Failed to open file: testing/this_file_does_not_exist.txt for buffer_load()
// Inherit the parent event | ||
event_inherited(); | ||
|
||
on_click = method({ target_room, category }, function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learn so many neat GML tricks from reading your code. My way of making pseudo-closures is so much more obnoxiously verbose than this
This comes from I attempt to read a buffer from potentially non-existent file as opposed to checking if file exists beforehand, because:
Thus, I don't think I can get rid of these messages, if I want to keep the "unable to load buffer for whatever reason" path tested. Glad the rest of the code looks good to go. ^^ |
I figured as much. And I agree that preventing the race condition wrt the file existing is more important than getting rid of a rogue line of unit test output. Just thought I'd bring it up in case you weren't aware. |
Addressing issue #115
The demos are now divided into categories, and selecting a category in the starting room will show its corresponding demos. This should allow adding more demos for a while, without the starting room getting overcrowded.