Add immutable flag to pending intents for Android 12 #1040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will lead to the app no longer crashing due to missing flags but does not take into account the new permissions for Android 12. Also the StartupBroadcastReceiver should be explicitly marked as exportable. These should be taken care of also (in a separate PR I guess?) |
Merged
|
Thanks, @nbadal. I have merged this into #1043 with other Android 12 changes. @CanYumusak please see discussion of permission changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As required in Android 12.
As far as I can tell none of these intents need to be mutable, but let me know if that's wrong!