maint: Avoid loading shared libraries more than once #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AltF02
reviewed
Jan 4, 2023
|
@AltF02 Any chance you could take another look at this? This is a soundness issue as much as a convenience issue, since it gets rid of the bespoke unsafe code for shared library initialization. |
|
Hi, excuses. I was very busy the past weeks |
AltF02
approved these changes
Jan 18, 2023
|
Released under v2.21.0 |
RalfJung
reviewed
Jan 28, 2025
Comment on lines
-40
to
-42
| $((stringify!($fn_name), &((*core::ptr::null::<$struct_name>()).$fn_name) as *const _ as usize),)* | ||
| $((stringify!($vfn_name), &((*core::ptr::null::<$struct_name>()).$vfn_name) as *const _ as usize),)* | ||
| $((stringify!($var_name), &((*core::ptr::null::<$struct_name>()).$var_name) as *const _ as usize),)* |
There was a problem hiding this comment.
Also FYI, the old code that was removed here has Undefined Behavior -- offsetting a null pointer by a non-zero amount (such as to project to the field, as in this code) is not allowed. Lucky enough we have offset_of! these days which makes it much less likely that people write code like this. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersThis PR makes it so the X11 linked libraries are only loaded once. This PR also replaces
lazy_staticwith theonce_cellcrate, sincelazy_statichas largely been replaced withonce_cellwithin the Rust ecosystem.