Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/demo routes #17

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Fix/demo routes #17

merged 3 commits into from
Mar 12, 2021

Conversation

ArkuVonSymfon
Copy link
Contributor

No description provided.

Copy link
Contributor

@tomaszantas tomaszantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix and we are ready to go!

if (e.target.value.length !== 0) {
setErrorData({ ...errorData, [target]: false })
} else {
setErrorData({ ...errorData, [target]: true })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify it to something like this:

setErrorData({ ...errorData, [target]: e.target.value.length !== 0 })

if (e.target.value.length !== 0) {
setErrorData({ ...errorData, [target]: false })
} else {
setErrorData({ ...errorData, [target]: true })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same like in the EmailPasswordForm

@ArkuVonSymfon ArkuVonSymfon merged commit a576d50 into master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants