-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added AuthComponent #9
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import React, { useState } from 'react' | ||
import SignIn from '../../containers/SignInContainer' | ||
import SignUp from '../../containers/SignUpContainer' | ||
import ForgotPassword from '../../containers/ForgotPasswordContainer' | ||
|
||
export interface IAuthProps { | ||
className?: string | ||
} | ||
|
||
const AuthComponent = ({ | ||
className = 'a6y-react-auth', | ||
}: IAuthProps): JSX.Element => { | ||
const [currentForm] = useState('sign-in') | ||
const getAuthForm = (): JSX.Element => { | ||
switch (currentForm) { | ||
case 'sign-up': | ||
return <SignUp /> | ||
case 'forgot-password': | ||
return <ForgotPassword /> | ||
default: | ||
return <SignIn /> | ||
} | ||
} | ||
return <div className={className}>{getAuthForm()}</div> | ||
} | ||
|
||
export default AuthComponent |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import Auth from './Auth' | ||
export default Auth |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export * from './components/EmailPasswordForm' | ||
import Auth from './components/AuthComponent' | ||
export default Auth |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import React from 'react' | ||
import { render } from '@testing-library/react' | ||
import AuthComponent from '../../components/AuthComponent' | ||
|
||
describe(`Component:Auth test`, () => { | ||
it('renders without crashing', () => { | ||
const rendered = render(<AuthComponent />) | ||
expect(rendered).toBeDefined | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import React from 'react' | ||
import { Meta } from '@storybook/react' | ||
import Auth from '../../src/components/AuthComponent' | ||
|
||
export const AuthComponent: React.VFC<unknown> = args => <Auth {...args} /> | ||
|
||
export default { | ||
title: 'Components/Auth', | ||
component: Auth, | ||
} as Meta |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to change here, just sharing my thoughts that maybe we should figure out some better naming convention for CSS classes. I believe that
-cnt
means the "container" here, but is it named that way because it is inSignInContainer
file or because thisdiv
acts as a container/wrapper.Maybe in the future, we will try to standardize it a bit.