Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query bookmarks feedback updates #1305

Merged
merged 5 commits into from
Jul 17, 2024
Merged

fix: query bookmarks feedback updates #1305

merged 5 commits into from
Jul 17, 2024

Conversation

saravmajestic
Copy link
Collaborator

@saravmajestic saravmajestic commented Jul 15, 2024 •
edited
Loading

Overview

Changes

  • use model name in virtual document file name
  • remove contact us option in preview panel if bookmarks is enabled
  • fixed error while opening new query file
  • show user name in shared bookmarks row
  • fix delete a test in dbt1.8 with data_tests format

Solution

Describe the implemented solution. Add external references if needed.

Screenshot/Demo

image

How to test

  • Steps to be followed to verify the solution or code changes
  • Mention if there is any settings configuration added/changed/deleted

Checklist

  • I have run this code and it appears to resolve the stated issue
  • README.md updated and added information about my change

@anandgupta42 anandgupta42 merged commit b9997ad into master Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdesmet mdesmet Awaiting requested review from mdesmet

@AdiGajbhiye AdiGajbhiye Awaiting requested review from AdiGajbhiye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saravmajestic @anandgupta42