Fill Labels attribute of a DataFrame Field. #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my goal is support for alerting on multiple series.
This issue has been reported in #362. See point two with the reference to grafana/grafana#7832
It appears that grafana uses the
Labels
of aField
within aDateFrame
to distinguish/track the different alerts. Currently the clickhouse-grafana plugin leaves theLabels
empty.So grafana does not know how the multiple DataFrames differ and shows the following error instead:
In this pull request I fill the
Labels
attribute and now alerting of multiple series works as expected.See the following screenshot. The important bit as at the end after the 'Preview Alerts'.
There is a list with the different series, based on the labels. Which means the grafana alert tracking looks at the different series independently.
Without this fix the alert would raise this error instead.