Helm chart - allow adding additional pod labels to deployment

[bruno-s-coelho]

Hi all 👋

As I can see, we can set pod annotations dynamically. However, we can't set labels. All labels are created with helpers, and we can't create additional new ones, as we can see here.

Would be possible to allow us to add new labels? As we can do with annotations?

Thanks,
Bruno

[Slach]

Which pod exactly do you mean? clickhouse-operator? or pod with clickhouse-server?

[bruno-s-coelho]

Hi 👋

clickhouse-operator

[Slach]

feel free to make pull request look to
https://github.com/Altinity/clickhouse-operator/blob/master/dev/generate_helm_chart.sh and try to figure out

[bruno-s-coelho]

Hi @Slach,

I tried to create a new PR however I had the following error:

➜  dev git:(master) ✗ git checkout 0.23.3
M       deploy/helm/README.md
M       deploy/helm/templates/_helpers.tpl
M       deploy/helm/templates/generated/Deployment-clickhouse-operator.yaml
M       deploy/helm/templates/generated/ServiceAccount-clickhouse-operator.yaml
M       dev/generate_helm_chart.sh
branch '0.23.3' set up to track 'origin/0.23.3'.
Switched to a new branch '0.23.3'

➜  dev git:(0.23.3) ✗ git checkout -b issue_1356
Switched to a new branch 'issue_1356'

➜  dev git:(issue_1356) ✗ git add -A && git commit -m "Issue 1356 Update helm chart to allow add pod labels" && git push
[issue_1356 8386c692] Issue 1356 Update helm chart to allow add pod labels
 5 files changed, 7 insertions(+), 3 deletions(-)
fatal: The current branch issue_1356 has no upstream branch.
To push the current branch and set the remote as upstream, use

    git push --set-upstream origin issue_1356

To have this happen automatically for branches without a tracking
upstream, see 'push.autoSetupRemote' in 'git help config'.

➜  dev git:(issue_1356)     git push --set-upstream origin issue_1356
ERROR: Permission to Altinity/clickhouse-operator.git denied to bruno-s-coelho.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Can you help me here?
Thanks,
Bruno

[Slach]

@bruno-s-coelho create fork in your personal account
after that you can create pull request

[bruno-s-coelho]

Hi @Slach,

PR created -> #1359

Thanks,
Bruno

[bruno-s-coelho]

Hi @Slach,

Thanks for helping. Do you know when release 0.24.0 will be released?
Thanks,
Bruno

[bruno-s-coelho]

Hi @Slach,
Just noticed that we already have a branch 0.23.4. Could we add these modifications to that branch too?
Seems like 0.24.0 will take time to be released.

[Slach]

@bruno-s-coelho please create new PR to 0.23.4 i will merge it

[bruno-s-coelho]

Hi @Slach,

Done -> #1369

Thanks,
Bruno