Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1356 Update helm chart to allow add pod labels #1359

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

bruno-s-coelho
Copy link
Contributor

Thanks for taking the time to contribute to clickhouse-operator!

Please, read carefully instructions on how to make a Pull Request.

This will help a lot for maintainers to adopt your Pull Request.

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

Copy link
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add changes to values.yaml with comments to allow describe new labels in helm/README.md ?

@bruno-s-coelho
Copy link
Contributor Author

Yes, I forget that. Already pushed a new commit with that changes @Slach

@Slach Slach merged commit f49d8c6 into Altinity:0.24.0 Mar 4, 2024
@Slach
Copy link
Collaborator

Slach commented Mar 4, 2024

thanks for contibuting

@bruno-s-coelho bruno-s-coelho deleted the issue_1356 branch March 5, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants