GrafanaDisk Space Free dashboard is not working with clickhouse v24.3+

[lesandie]

About prometheus metrics, in latest clickhouse versions (24) asynchronous metrics for disks look the same but some dashboards stopped working. The operator prometheus writer is generating these metrics DiskFreeBytes/DiskTotalBytes based on clickhouse metrics.

Do we need to update the writer to read correct metrics for versions 24?. We found this because grafana cluster dashboard Disk Space Free is not working.

clickhouse-operator/pkg/apis/metrics/prometheus_writer.go

Line 176 in d5f265f

// WriteSystemDisks writes system disks

SELECT *
FROM system.asynchronous_metrics
WHERE metric ILIKE '%disk%'
   ┌─metric─────────────────┬────────value─┬─description────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
1. │ DiskUnreserved_default │ 682223263744 │ Available bytes on the disk (virtual filesystem) without the reservations for merges, fetches, and moves. Remote filesystems may not provide this information. │
2. │ DiskUsed_default       │ 299826171904 │ Used bytes on the disk (virtual filesystem). Remote filesystems not always provide this information.                                                           │
3. │ DiskTotal_default      │ 982049435648 │ The total size in bytes of the disk (virtual filesystem). Remote filesystems may not provide this information.                                                 │
4. │ DiskAvailable_default  │ 682223263744 │ Available bytes on the disk (virtual filesystem). Remote filesystems may not provide this information.                                                         │
   └────────────────────────┴──────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

Also other dashboards may be affected.

[Slach]

check operator version 0.23.7
#1411