Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClickHouse disk type with first upper letter #1411

Closed
orloffv opened this issue May 3, 2024 · 5 comments
Closed

ClickHouse disk type with first upper letter #1411

orloffv opened this issue May 3, 2024 · 5 comments
Assignees
@Slach

Comments

@orloffv
Copy link
Contributor

orloffv commented May 3, 2024

clickhouse-operator/pkg/apis/metrics/clickhouse_metrics_fetcher.go

Line 119 in bbbf66a

WHERE type = 'local'

Screenshot 2024-05-03 at 11 09 26

i added new disk for example:

	"storage_configuration/disks/disk1/type": "local"
	"storage_configuration/disks/disk1/path": "/var/log/clickhouse-server/"
	"storage_configuration/disks/disk1/keep_free_space_bytes": 100000

and type is "Local"
the metrics aren't fetched.
@orloffv
Copy link
Contributor Author

orloffv commented May 3, 2024

clickhouse version is 24.4.1.2088

@orloffv
Copy link
Contributor Author

orloffv commented May 3, 2024 •
edited
Loading

https://fiddle.clickhouse.com/4ca0bd51-54d4-45c1-9896-0d7c2bafdc39 24.2.3 - local
https://fiddle.clickhouse.com/1255275d-d46a-4fdd-89de-520f07250315 24.3.1 - Local

@Slach
Copy link
Collaborator

Slach commented May 3, 2024

thanks for reporting

@Slach Slach self-assigned this May 3, 2024
Slach added a commit that referenced this issue May 3, 2024
@Slach
fix incompatiblity in disk type for clickhouse 24.3 - fix #1411
5e29eaa 
Signed-off-by: Slach <bloodjazman@gmail.com>
@alex-zaitsev
Copy link
Member

Fixed in 0.24.0

sunsingerus pushed a commit that referenced this issue Aug 12, 2024
@Slach @sunsingerus
fix incompatiblity in disk type for clickhouse 24.3 - fix #1411
8ce5729 
Signed-off-by: Slach <bloodjazman@gmail.com>
@alex-zaitsev
Copy link
Member

Fix is delivered in https://github.com/Altinity/clickhouse-operator/releases/tag/release-0.23.7 as well

@Slach Slach mentioned this issue Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Slach Slach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Slach @orloffv @alex-zaitsev