Skip to content

Commit c690a5c

Browse files
authored
Be more consistent with how we log custom dimensions (#424)
1 parent 4877f47 commit c690a5c

File tree

4 files changed

+20
-1
lines changed

4 files changed

+20
-1
lines changed

src/Altinn.Broker.Application/Altinn.Broker.Application.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="8.0.0" />
1414
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.1" />
1515
<PackageReference Include="OneOf" Version="3.0.263" />
16+
<PackageReference Include="Serilog" Version="3.1.1" />
1617
</ItemGroup>
1718

1819
<ItemGroup>

src/Altinn.Broker.Application/InitializeFileTransferCommand/InitializeFileTransferCommandHandler.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
using Altinn.Broker.Application.ExpireFileTransferCommand;
1+
using System;
2+
3+
using Altinn.Broker.Application.ExpireFileTransferCommand;
24
using Altinn.Broker.Core.Application;
35
using Altinn.Broker.Core.Domain.Enums;
46
using Altinn.Broker.Core.Repositories;
@@ -11,6 +13,8 @@
1113

1214
using OneOf;
1315

16+
using Serilog.Context;
17+
1418
namespace Altinn.Broker.Application.InitializeFileTransferCommand;
1519
public class InitializeFileTransferCommandHandler : IHandler<InitializeFileTransferCommandRequest, Guid>
1620
{
@@ -65,6 +69,7 @@ public async Task<OneOf<Guid, Error>> Process(InitializeFileTransferCommandReque
6569
}
6670
var fileExpirationTime = DateTime.UtcNow.Add(resource.FileTransferTimeToLive ?? TimeSpan.FromDays(30));
6771
var fileTransferId = await _fileTransferRepository.AddFileTransfer(serviceOwner, resource, request.FileName, request.SendersFileTransferReference, request.SenderExternalId, request.RecipientExternalIds, fileExpirationTime, request.PropertyList, request.Checksum, null, null, cancellationToken);
72+
LogContext.PushProperty("fileTransferId", fileTransferId);
6873
await _fileTransferStatusRepository.InsertFileTransferStatus(fileTransferId, FileTransferStatus.Initialized, cancellationToken: cancellationToken);
6974
var addRecipientEventTasks = request.RecipientExternalIds.Select(recipientId => _actorFileTransferStatusRepository.InsertActorFileTransferStatus(fileTransferId, ActorFileTransferStatus.Initialized, recipientId, cancellationToken));
7075
try

src/Altinn.Broker.Persistence/Altinn.Broker.Persistence.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<PackageReference Include="Hangfire.PostgreSql" Version="1.20.8" />
2121
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="25.0.0" />
2222
<PackageReference Include="Npgsql" Version="8.0.2" />
23+
<PackageReference Include="Serilog" Version="3.1.1" />
2324
<PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="7.5.1" />
2425
</ItemGroup>
2526

src/Altinn.Broker.Persistence/Repositories/FileTransferRepository.cs

+12
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88

99
using NpgsqlTypes;
1010

11+
using Serilog.Context;
12+
1113
namespace Altinn.Broker.Persistence.Repositories;
1214

1315
public class FileTransferRepository : IFileTransferRepository
@@ -110,9 +112,19 @@ GROUP BY
110112
}
111113
fileTransfer.RecipientCurrentStatuses = await GetLatestRecipientFileTransferStatuses(fileTransferId, cancellationToken);
112114
fileTransfer.PropertyList = await GetMetadata(fileTransferId, cancellationToken);
115+
EnrichLogs(fileTransfer);
113116
return fileTransfer;
114117
}
115118

119+
private static void EnrichLogs(FileTransferEntity fileTransferEntity)
120+
{
121+
LogContext.PushProperty("fileTransferId", fileTransferEntity.FileTransferId);
122+
LogContext.PushProperty("resourceId", fileTransferEntity.ResourceId);
123+
LogContext.PushProperty("sender", fileTransferEntity.Sender);
124+
LogContext.PushProperty("recipients", string.Join(',', fileTransferEntity.RecipientCurrentStatuses.Select(status => status.Actor.ActorExternalId)));
125+
LogContext.PushProperty("fileName", fileTransferEntity.FileName);
126+
LogContext.PushProperty("status", fileTransferEntity.FileTransferStatusEntity.Status.ToString());
127+
}
116128

117129
/*
118130
* Get the current status of a file tranfer's recipients along wiith the last time their status changed.

0 commit comments

Comments
 (0)