Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved custom dimensions in logs #424

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented May 6, 2024

Description

Make sure all custom data is added to the log context as soon as possible so that subsequent log entries will be searchable.
Example of how it can be used:

traces 
| extend fileTransferId = customDimensions.fileTransferId
| where fileTransferId == '1d970eec-c9d9-4c94-8a63-fea392b3aa38'

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron changed the title Be more consistent with how we log custom dimensions Improved consistency with custom dimensions in logs May 6, 2024
@Ceredron Ceredron changed the title Improved consistency with custom dimensions in logs Improved custom dimensions in logs May 6, 2024
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ceredron Ceredron merged commit c690a5c into main May 7, 2024
@Ceredron Ceredron deleted the chore/consistent-logging branch May 7, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants