Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource to domain #281

Merged
merged 10 commits into from
Jan 22, 2024
Merged

Add resource to domain #281

merged 10 commits into from
Jan 22, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented Jan 17, 2024

Description

Change the simple service model with resource model that is more aligned with end state.

Actual RR/RRR integration where the database tables are replaced with network calls to RR/RRR in staging/prod.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron marked this pull request as ready for review January 18, 2024 08:31
Copy link
Collaborator

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a small change of the location for Org number from Resource to Resource Owner :)
But we should discuss if we can use the "Resource" / "Resource Owner" concept instead of "Service Owner" with the product owner. I will start the discussion

@Ceredron Ceredron merged commit 53c45a4 into main Jan 22, 2024
@Ceredron Ceredron deleted the chore/rewrite-service-to-resource branch January 22, 2024 08:32
@Ceredron Ceredron mentioned this pull request Jan 24, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants