Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .API suffix #296

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Add .API suffix #296

merged 4 commits into from
Feb 1, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented Jan 31, 2024 •
edited
Loading

Description

Change suggestion: Add .API suffix to our API project so that all projects have a suffix that describes their role in the project

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron marked this pull request as ready for review January 31, 2024 14:34
RagnarFatland-Avanade
RagnarFatland-Avanade approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! More explicit naming is always welcome in my book.

@Ceredron Ceredron merged commit a38f17f into main Feb 1, 2024
1 check passed
@Ceredron Ceredron deleted the chore/suffix-all-projects branch February 1, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RagnarFatland-Avanade RagnarFatland-Avanade RagnarFatland-Avanade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ceredron @RagnarFatland-Avanade