Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated LegacyFileController to receive FileTransferStatus #357

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

tomshag
Copy link
Contributor

@tomshag tomshag commented Mar 14, 2024

Description

LegacyFileController should receive a FileTransferStatus value in its request.
Technically this should always be status "Published" received from Altinn 2, but we will keep it as a variable.
We mistakenly removed this property in the initial checkin.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@tomshag tomshag requested review from RagnarFatland and Andreass2 and removed request for RagnarFatland March 14, 2024 10:55
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@RagnarFatland RagnarFatland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but consider adding a unit test to verify the functionality and demonstrating the need for this change.

@tomshag tomshag merged commit ee05e16 into main Mar 15, 2024
1 check passed
@tomshag tomshag deleted the Feature/251-GetAvailableFiles_FileStatus branch March 15, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants