Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Legacy GetFiles to treat Initialized and DownloadStarted as t… #368

Conversation

tomshag
Copy link
Contributor

@tomshag tomshag commented Mar 26, 2024

…he same status, since Altinn 2 does not consider them to be different statuses.

Description

Altinn 2 only understands the status of "Initialized", which it calls "Uploaded", and "DownloadConfirmed".
Because of this, Altinn Legacy bridge in Altinn 3 must treat Initialized and DownloadStarted as the same status when receiving requests from Altinn 2.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

…he same status, since Altinn 2 does not consider them to be different statuses.
@tomshag tomshag requested review from Ceredron and Andreass2 March 26, 2024 12:17
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
But I think it might be smart to include a comment in the FileTransferRepository.cs explaining why.

ps. remember to run dotnet format :)

@RagnarFatland RagnarFatland merged commit f00e32d into main Apr 2, 2024
1 check passed
@RagnarFatland RagnarFatland deleted the Feature/251-GetAvailableFiles_Legacy_InitializedIncludesDownloadStarted branch April 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants