Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR tests #427

Merged
merged 10 commits into from
May 8, 2024
Merged

Fix PR tests #427

merged 10 commits into from
May 8, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented May 8, 2024

Description

This action will be setup so that it has to run green in order to be able to merge to main.

Old test workflow did not work because it tried to use Sonarcloud without the necessary setup. We can consider whether we want to use Sonarcloud down the line and how it should be configured - maybe after talking with some other teams who use it. Searching Slack I could only find people having issues with it (and stopping to use it).

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

@Ceredron Ceredron merged commit 7d808c1 into main May 8, 2024
@Ceredron Ceredron deleted the chore/fix-pr-test branch May 8, 2024 18:22
@Ceredron Ceredron mentioned this pull request May 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants