Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github environments #439

Merged
merged 7 commits into from
May 21, 2024
Merged

Github environments #439

merged 7 commits into from
May 21, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented May 16, 2024

Description

Re-wrote to use Github environments.

We now have one single workflow for the CI/CD process. Whenever something is pushed to main, we build and push a new version. We then roll it out to every environment. It will be possible to setup review steps, for instance if developers want to approve it before deploying to production.

It is also possible to deploy the solution to a new environment by using the deploy-solution workflow directly.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron changed the title Re-write to use Github environments. Also re-factored out some extra … Github environments May 16, 2024
@Ceredron Ceredron marked this pull request as ready for review May 16, 2024 10:16
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Much cleaner solution aswell.

@Ceredron Ceredron merged commit 0391f7b into main May 21, 2024
2 checks passed
@Ceredron Ceredron deleted the feat/github-environments branch May 21, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants