Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button component: merge provided className #198

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

bjosttveit
Copy link
Member

Description

Quick fix that merges className from props into button's classNames. Previously providing a custom className would override all styling since the restProps were inserted last.

Related Issue(s)

@bjosttveit bjosttveit requested a review from Magnusrm November 14, 2022 12:17
@bjosttveit
Copy link
Member Author

bjosttveit commented Nov 14, 2022

Looks quite funny though 😆

image

@codecov-commenter
Copy link

Codecov Report

Base: 93.57% // Head: 93.57% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (04dc3ec) compared to base (148de49).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files          72       72           
  Lines         980      981    +1     
  Branches      281      281           
=======================================
+ Hits          917      918    +1     
  Misses         59       59           
  Partials        4        4           
Impacted Files Coverage Δ
src/components/Button/Button.tsx 92.50% <100.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bjosttveit bjosttveit merged commit 1963f7f into main Nov 14, 2022
@bjosttveit bjosttveit deleted the button-classname branch November 14, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants