Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map component #60

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Map component #60

merged 1 commit into from
Aug 8, 2022

Conversation

josteitv
Copy link
Contributor

@josteitv josteitv commented Jul 4, 2022

Generic map component

Description

Generic map component for selecting a lat/lon location as described in Altinn/altinn-studio#8480

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@RonnyB71 RonnyB71 added the external-contribution-❤️ Pull request from a developer outside the Altinn teams. label Jul 6, 2022
mjulstein
mjulstein reviewed Jul 6, 2022
View reviewed changes
jest.config.js Outdated Show resolved Hide resolved
@josteitv josteitv mentioned this pull request Jul 6, 2022
Merged
5 tasks
@josteitv josteitv requested a review from mjulstein July 6, 2022 20:44
haakemon
haakemon suggested changes Jul 7, 2022
View reviewed changes
src/components/Map/Map.test.tsx Outdated Show resolved Hide resolved
src/components/Map/Map.tsx Outdated Show resolved Hide resolved
src/components/Map/Map.tsx Outdated Show resolved Hide resolved
src/components/Map/Map.tsx Outdated Show resolved Hide resolved
src/components/index.ts Show resolved Hide resolved
rollup.config.js Show resolved Hide resolved
@haakemon haakemon mentioned this pull request Jul 7, 2022
Closed
2 tasks
@josteitv josteitv requested a review from haakemon July 7, 2022 09:50
@haakemon haakemon mentioned this pull request Jul 7, 2022
Open
haakemon
haakemon suggested changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@haakemon haakemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, some final notes 😅

src/components/Map/Map.test.tsx Outdated Show resolved Hide resolved
src/components/Map/Map.test.tsx Outdated Show resolved Hide resolved
src/components/Map/Map.test.tsx Outdated Show resolved Hide resolved
src/components/Map/Map.test.tsx Outdated Show resolved Hide resolved
src/components/Map/Map.test.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #60 (1cbf2fd) into main (a75935e) will decrease coverage by 0.97%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   97.74%   96.77%   -0.98%     
==========================================
  Files          15       19       +4     
  Lines         222      279      +57     
  Branches       58       71      +13     
==========================================
+ Hits          217      270      +53     
- Misses          5        9       +4
Impacted Files Coverage Δ
src/components/Accordion/Context.ts 85.71% <ø> (ø)
src/components/Button/Button.tsx 100.00% <ø> (ø)
src/components/Panel/Panel.tsx 100.00% <ø> (ø)
src/components/TextField/TextField.tsx 100.00% <ø> (ø)
src/components/List/Context.ts 90.00% <90.00%> (ø)
src/components/Map/Map.tsx 90.62% <90.62%> (ø)
src/components/List/List.tsx 100.00% <100.00%> (ø)
src/components/List/ListItem.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@josteitv josteitv requested a review from haakemon August 8, 2022 11:21
haakemon
haakemon approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@haakemon haakemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🥇

@haakemon haakemon merged commit 29d422c into Altinn:main Aug 8, 2022
@haakemon haakemon mentioned this pull request Aug 9, 2022
Merged
4 tasks
@josteitv josteitv deleted the feature/map-component branch March 15, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakemon haakemon haakemon approved these changes

@mjulstein mjulstein Awaiting requested review from mjulstein

Assignees
No one assigned
Labels
external-contribution-❤️ Pull request from a developer outside the Altinn teams.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josteitv @codecov-commenter @haakemon @mjulstein @RonnyB71