create input component #61
Conversation
…ature/input-component # Conflicts: # package.json # yarn.lock
… condition result into one
…witch statement when only 1 condition
…est for TextField utils
…ature/input-component
…m inline change handler to improve readability
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 96.81% 97.73% +0.92%
==========================================
Files 12 15 +3
Lines 157 221 +64
Branches 36 58 +22
==========================================
+ Hits 152 216 +64
Misses 5 5
Continue to review full report at Codecov.
|
…gn with how native input works
…id layout shift on focus
…nually expose each native input property This has a downside where NumberFormat component does not have as broad type definition, so we cannot pass 'rest' props to that component
|
Design system v2 is setting font-size: inherit;
line-height: inherit;which computes to 16px for font-size and 24px for line-height. This causes the inputfields to be much bigger when introduced in app-frontend repo. We need to look into how to deal with this, as the inputfields should be 36px tall. Currently they will be 40px instead because of the inherited values. |
…ature/input-component # Conflicts: # src/components/index.ts
…side element. Subtract the border width from the padding to fix the issue
|
Height issue has been partially fixed. It looks good when the component is used in app-frontend, but it doesnt look correct when viewed in Storybook. Created a separate task to follow up this issue #76 |
Create input component using design system
Issue
fixes #47 Input component
Verification