Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JWTCookie Refresh in App-Frontend application #1718

Closed
5 tasks done
TheTechArch opened this issue May 11, 2019 · 4 comments
Closed
5 tasks done

Implement JWTCookie Refresh in App-Frontend application #1718

TheTechArch opened this issue May 11, 2019 · 4 comments
Labels
area/authentication Area: Issues related to authentication in Altinn Studio kind/user-story Used for issues that describes functionality for our users.
Milestone

Comments

@TheTechArch
Copy link
Member

TheTechArch commented May 11, 2019

Description

The app-frontend would need to refresh the JWTCookie in intervals as long that a user is doing stuff. This to keep the user logged in.

image.png

Considerations

SBL must handle the JWT cookie and convert it to their own cookie format when navigating.
Risk for ending up with a forever living session

Acceptance criteria

  • User is kept logged in as long he has a active session
  • User is not kept logged in if he doest not have activity
  • The refreshed JWT token is properly signed
  • Expired or invalid JWT token is not refreshable

Tasks

  • Implement endpoint in Platform Authentication for refreshing JWTCookie
  • Implement endpoint + SI implementation for refreshing cookie in app backend
  • Implement logic to call refresh endpoint at intervalls from app frontend
  • Update documentation
  • Manual test
@TheTechArch TheTechArch added kind/user-story Used for issues that describes functionality for our users. area/authentication Area: Issues related to authentication in Altinn Studio runtime labels May 11, 2019
This was referenced May 12, 2019
@lvbachmann lvbachmann added this to the MVP.2 milestone May 14, 2019
@TheTechArch TheTechArch changed the title Implement JWTCookie Refresh in Runtime React application Implement JWTCookie Refresh in App-Frontend application Jun 24, 2019
@ghost ghost self-assigned this Sep 5, 2019
@GGunnar GGunnar modified the milestones: MVP.2, MVP.3 Sep 12, 2019
@acn-sbuad acn-sbuad assigned acn-sbuad and unassigned acn-sbuad Sep 17, 2019
@jezpoz
Copy link
Contributor

jezpoz commented Sep 20, 2019

Assigning myself to work on the app-frontend.
Also added team tamagotchi tag since thats the best team, because I'm on that team.

@jezpoz jezpoz self-assigned this Sep 20, 2019
@trymen trymen self-assigned this Sep 23, 2019
@jezpoz
Copy link
Contributor

jezpoz commented Sep 23, 2019

Frontend part of this task is in PR: #2609

@jezpoz
Copy link
Contributor

jezpoz commented Sep 24, 2019

After a review of frontend-code, Team Tamagotchi wants to make a more performant solution for this. Or at least come up with a more performant solution that is approved by our interaction designers.

The improvement issue can be worked with at a later stage.
Issue: Altinn/app-frontend-react#105

@trymen
Copy link
Contributor

trymen commented Sep 30, 2019

Tested in at21, keepAlive verified to be triggered, and user can continue the workflow. Closing this issue as completed.

@trymen trymen unassigned trymen and ghost Sep 30, 2019
@GGunnar GGunnar modified the milestones: MVP.3, MVP.3.1 Oct 8, 2019
@Kritsi Kritsi modified the milestones: MVP.3.1, v2019.41 Oct 18, 2019
@GGunnar GGunnar modified the milestones: v2019.41, MVP.3.2 Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/authentication Area: Issues related to authentication in Altinn Studio kind/user-story Used for issues that describes functionality for our users.
Projects
None yet
Development

No branches or pull requests

7 participants