Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize JWT token refresh app-frontend #105

Open
2 tasks
jezpoz opened this issue Sep 24, 2019 · 3 comments
Open
2 tasks

Optimize JWT token refresh app-frontend #105

jezpoz opened this issue Sep 24, 2019 · 3 comments

Comments

@jezpoz
Copy link
Contributor

jezpoz commented Sep 24, 2019

Description

JWT-token refresh in app-frontend is implemented in a way that it uses "alot" of CPU resources. On a fairly new macbook it jumps from 0.3% (idle) to 3% load when moving the mouse. The increased usage of CPU could be noticeable on a "weaker" pc.

A suggested solution is that we do how netbanks handles sessions, where a little notification shows up a little while before the token expires. It should say something like "Your session is expiring soon, do you want to keep working?" and have an ok-button.

In scope

  • How long is the token valid?
  • What must a user do to be classified as active?
  • How often should we refresh the token?
  • How do we implement the checks if the token should be active?

Constraints

Analysis

Conclusion

Short summary of the proposed solution.

Tasks

  • Is this issue labeled with a correct area label?
  • QA has been done
@HanneLauritsen1967
Copy link
Member

@jezpoz hei er det du i tamagotchi som jobber med denne? Siste issues for epic 1304

@GGunnar GGunnar changed the title JWT token refresh app-frontend Optimize JWT token refresh app-frontend Oct 16, 2019
@matsgm
Copy link
Contributor

matsgm commented Nov 6, 2019

Look at Adal from Microsoft for tips on refreshing.

@jezpoz
Copy link
Contributor Author

jezpoz commented Nov 25, 2019

I was thinking that this could be a specification with UX and technical. Since we need to know what should classify as a user begin active. And also use the time to come up with a better technological solution for this, since some of the developers did not like the implementation of this. (Not mentioning any by name, isn't that right @lorang92? 😂)

@lvbachmann lvbachmann added kind/analysis and removed kind/feature-request New feature or request labels May 15, 2020
@haakemon haakemon transferred this issue from Altinn/altinn-studio May 19, 2022
olemartinorg pushed a commit that referenced this issue Nov 2, 2022
Co-authored-by: EKEBERG Steffen <steffen.ekeberg@soprasteria.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants