Functionality for "Forgot password"

[GGunnar]

Description

Today the only way to reset password is with admin interaction. We should automate this process so that there is no need for human intervention for users who have forgot their password.

We should set up an email server that could be used to send an email with link for reset of password using existing functionality in Gitea that is currently disabled.

Screenshot

https://www.figma.com/file/EG80RgF70SgMyewzKpb5fJ9M/Altinn-Studio?node-id=598%3A8742

Default UI in Gitea:

Navigation from/to (if relevant)

From Login page
On landing page you will have two choices:

• go back to home page by clicking on altinn icon
• Button to reset password

Technical considerations

• Configuration needs to use environment variables so secrets are not part of altinn-studio repo
• Consider if recaptcha should be enabled (to avoid spam users)
• Will email notifications with pr be included?

Acceptance criterea

• We have a secure mail service that studio and gitea can utilize
• Gitea is properly configured to use the mail service
• Forgot password functionality s working
• Confirmation mail for registering new Gitea-users is sent

Design/Functional Tasks

- [ ] Email template for the reset password functionality (if possible to modify)

• Formulate text to be shown after password (translate Gitea text to norwegian)

Development Tasks

• Set up email server
• Update Gitea app.ini
  • Required mail config (as env. variables and use of secrets)
  • Also set REGISTER_EMAIL_CONFIRM = true
  • Also set ENABLE_NOTIFY_EMAIL = true
• Confirm IP for production
  - [ ] Override authz e-mail templates in repository and ensure correct norwegian texts. Doc on how to

Test/QA

• Verify if emails are sent out
  - [ ] No mix of norwegian and english text, everything should be norwegian refer comment
• Email sent during registration of new user
• Email sent for forgot password

[acn-dgopa]

@GGunnar what is the acceptance criteria or functionality for github users?

[acn-dgopa]

@GGunnar Also need input on the accepted email template. I have created tasks for the same

[GGunnar]

This issue concerns only functionality for "forgot password" for Gitea users, hence it should be clear for the user that the functionality is only for this user and not the Github user.

[acn-sbuad]

technical tasks completed. I suggest we create a new issue for nice to have feature such as design for the email.s

[acn-sbuad]

design extracted into seperate issue #6133

[acn-sbuad]

Emails are sent based on the templates in the gitea repository, and text changes didn't have an effect, templates should be duplicated to ensure norwegian text

[altinnadmin]

@acn-sbuad We could override this https://github.com/go-gitea/gitea/blob/master/templates/mail/auth/reset_passwd.tmpl

But the question then becomes, is it possible to support multiple languages in these templates?
Seems like the answer is no, ref. go-gitea/gitea#3622 that is still open.

Changing the template to only Norwegian would be a quick "hack", but I don't think we should do that.
Support for Enliglish in Designer is more important IMHO.

[altinnadmin]

@acn-sbuad FYI, support seems to be on it's way in Gitea 1.15 (next release) go-gitea/gitea#14822.

[acn-sbuad]

After discussion with designers we will keep the norwegian template for now as the result would be emails containing both Norwegian and English, but follow up on the new feature from Gitea..

[acn-sbuad]

Keeping emails as is for now with the mixed language. Closing issue

[6543]

well since it point to gitea mail translation email ...
.. a smal info:

If you like to get full norwegian support, just translate strings on crowdin asap go-gitea/gitea#16200 got merged :)

[6543]

https://crowdin.com/project/gitea/no only has 15% translated and nothing approved - ok it wong go in with so less anyway ...

[altinnadmin]

Thanks for the info @6543 :)
I translated large parts of Gitea to Norwegian for our Altinn Studio solution a few years ago, the nb-NO file is located here.

I've not tried using crowdin yet, is it possible to upload a single file containing a complete translation?

[6543]

Well as project admin yes ;)

I'll try it. Best would if you & your team just maintain translation upstream so all will benefit.

you can use github as Oauth source, if you decide to create an acount let me know and I add you as provereader for norwegian :)

@altinnadmin

[6543]

@altinnadmin thanks now it's at 47% !! - PS: it only will be added if at least 25% are approved

https://github.com/go-gitea/gitea/blob/e7b47c5/build/update-locales.sh#L12

[altinnadmin]

@6543 Great! I've just created my crowdin-account now.

47%... Hmmm, seems like there's still room for improvements... 😁

I prefer doing the translation directly in the ini file, while testing in Gitea locally, way more efficient than using the crowdin UI, and testing is part of the process.

If I translate the rest, and you upload the new "100%-file", will I then be able to approve the translations, so we get to 100% translated and 100% approved for Norwegian Bokmål?

After that I could keep on maintaining the Norwegian translation upstream in crowdin, sounds like a fun little pet project that would benefit both Gitea and Altinn.

[6543]

do as you like - just make sure that you use the latest locale: https://github.com/go-gitea/gitea/blob/main/options/locale/locale_en-US.ini

and I only approve existing strings who already have at least 1 vote on crowdin - if i upload a new locale it is not approved - so you have to look throu all of them anyway :/

current no locale:
locale_no-NO.ini.zip

[6543]

@altinnadmin you have to Join https://crowdin.com/project/gitea :)

[altinnadmin]

@altinnadmin you have to Join https://crowdin.com/project/gitea :)

Done! :)

current no locale: locale_no-NO.ini.zip

Norwegian comes in two written versions, nb_NO (Norwegian Bokmål) and nn_NO (Norwegian Nynorsk).
Wouldn't it be better to use these codes instead of no_NO to be able to translate both languages?

All 3 variants seems to be present in crowdin now... 😅

[6543]

added prove-read rights to you ... feel free to chat with me via our discord server or create an issue if needed