Localize Email Templates

[6543]

close #14822

• auth
  • activate.tmpl
  • activate_email.tmpl
  • register_notify.tmpl
  • reset_passwd.tmpl
• issue
  • assigned.tmpl
  • default.tmpl
• notify
  • collaborator.tmpl
  • repo_transfer.tmpl
• release.tmpl

[codecov-commenter]

Codecov Report

Merging #16200 (4332116) into main (66f8da5) will decrease coverage by 0.01%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main   #16200      +/-   ##
==========================================
- Coverage   45.57%   45.55%   -0.02%     
==========================================
  Files         702      702              
  Lines       82917    82924       +7     
==========================================
- Hits        37787    37778       -9     
- Misses      39088    39102      +14     
- Partials     6042     6044       +2     

Impacted Files	Coverage Δ
services/mailer/mail.go	62.96% <20.00%> (-0.91%)	⬇️
services/mailer/mail_release.go	80.00% <100.00%> (+0.45%)	⬆️
services/mailer/mail_repo.go	82.05% <100.00%> (+0.47%)	⬆️
modules/avatar/avatar.go	47.72% <0.00%> (-4.55%)	⬇️
modules/charset/charset.go	71.71% <0.00%> (-4.05%)	⬇️
services/pull/temp_repo.go	26.59% <0.00%> (-3.20%)	⬇️
services/pull/check.go	25.51% <0.00%> (-2.76%)	⬇️
services/pull/patch.go	54.23% <0.00%> (-1.70%)	⬇️
services/pull/pull.go	42.41% <0.00%> (+0.43%)	⬆️
models/repo_list.go	77.82% <0.00%> (+0.77%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f8da5...4332116. Read the comment docs.

[zeripath]

Hmm... I think there's too much html in these and we could risk a translator either accidentally or deliberately adding bad html.

[6543]

just putting some words in it wont work ... since in other languages you have complete different text structures ...
thats why i put whole sentences in it - and this result in adding html to locales...
I try to split it up as much as it should work

[fnetX]

Some thoughts on that:

• the templates don't really have a lot of style, what about switching to plaintext, also for smaller sizes?
• splitting the translation strings should work fine with most languages, e.g. [Salutation], [activate-your-acc-with-link], [not-working-link], [greetings] ...
  • most HTML is paragraphs (each paragraph should be one translation line, this should not be a problem, this is also how UI translation is usually done
  • some formatting like bold parts are not really that necessary IMHO, I actually always found that a little confusing in Gitea emails
• providing the email templates in some kind of markup language (e.g. Markdown) and parsing them to HTML

[fnetX]

I'll just add some examples, I don't have the Go template syntax at hand rn, so I'll stick to some pseudo-ish code:

footer = <p>© <a target="_blank" rel="noopener noreferrer" href="%[1]s">%[2]s</a></p>
view_it_on_footer = <a href="%[1]s">View it on %[2]s</a>.

• first line - only im template (no custom translation necessary)
• second: have everything in a template alike <a href="{{var_one}}">{{ translate string_with(placeholder) }}</a>

activate_account.body = <p>Hi <b>%[1]s</b>, thanks for registering at %[4]s!</p><br><p>Please click the following link to activate your account within <b>%[2]s</b>:</p><br><p><a href="%[3]s">%[3]s</a></p><br><p>Not working? Try copying and pasting it to your browser.</p>

• the "Hi, ..." part is shared among most templates, make it really shared: <p>{{translate greeting}} <b>{{user}}</b>,
• alternatively you could also drop the special bold formatting, but having a separated name might still make sense, e.g. to allow it to be styled differently later
• the rest can be split into multiple strings IMHO, and I don't see any real need for the formatting here.

Is it technically possible to insert HTML into an escaped template? This would allow the translation part to be safe end HTML-free, but the placeholders being some prepared template parts? This would allow stuff like

issue_assigned.pull = @%[1]s assigned you to the pull request <a href="@%[2]s">#@%[3]d</a> in repository %[4]s.

to be turned into @%[1]s assigned you to the pull request %[2] in repository %[3] where 2 inserts the whole link snippet.
if not, I still think this can be worked around by having a second View-Pull button like above with the other link, so you can use {{translate explanation_text}}<br/><a ...>{{translate view_pull}}</a>

So far I think every situation can be worked around when switching to real templates for the emails if this is feasible?

[6543]

@fnetX did refactor it even more ... now it should be way better

[fnetX]

Read two comments in context ... will the Str2html escape the tags in the translation? I think so?

[6543]

🚀