-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add subform layoutset #13632
feat: Add subform layoutset #13632
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13632 +/- ##
==========================================
+ Coverage 94.23% 94.24% +0.01%
==========================================
Files 1528 1532 +4
Lines 20814 20868 +54
Branches 2511 2516 +5
==========================================
+ Hits 19614 19668 +54
Misses 951 951
Partials 249 249 ☔ View full report in Codecov by Sentry. |
frontend/packages/ux-editor/src/components/Elements/LayoutSetsContainer.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/LayoutSetsContainer.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/LayoutSetsContainer.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/SubForm/DeleteSubFormWrapper.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @lassopicasso! This looks good for me now. 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments to consider 🌟
backend/src/Designer/Services/Implementation/AppDevelopmentService.cs
Outdated
Show resolved
Hide resolved
frontend/app-development/hooks/mutations/useAddLayoutSetMutation.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/LayoutSetsContainer.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/SubForm/CreateSubFormWrapper.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/SubForm/SubFormUtils.test.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/SubForm/DeleteSubFormWrapper.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/SubForm/CreateSubFormWrapper.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🥳 Lets release the blocked issue 😈
Description
This PR introduces the ability for users to add subform layout sets when the feature flag
subForm
is enabled.Key Changes:
useValidateLayoutSetName
tasks
property, while subforms are identified by atype
property.Once this PR is merged, issue #13475 can be unblocked.
Related Issue(s)
Verification
Documentation