Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fixing flaky unit test on dashboard #13710

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 7, 2024

Description

  • Fixing flaky unit test on dashboard. I've run the test multiple times now and are never getting any error.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Oct 7, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 7, 2024
@wrt95 wrt95 changed the title fixing flaky unit test on dashboard refactor: fixing flaky unit test on dashboard Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (7b6b262) to head (db91959).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13710   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files        1582     1582           
  Lines       21365    21365           
  Branches     2549     2549           
=======================================
  Hits        20173    20173           
  Misses        943      943           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95 wrt95 added skip-manual-testing PRs that do not need to be tested manually team/studio-core labels Oct 9, 2024
@wrt95 wrt95 merged commit b3b551c into main Oct 9, 2024
11 of 12 checks passed
@wrt95 wrt95 deleted the refactor-fix-flaky-unit-test-on-dashboard branch October 9, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Area: Related to the dashboard application frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky unit test on dashboard
2 participants