Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete old unused Altinn header #13745

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 9, 2024

Description

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 marked this pull request as draft October 9, 2024 06:00
@github-actions github-actions bot added area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 9, 2024
@wrt95 wrt95 self-assigned this Oct 9, 2024
@wrt95
Copy link
Contributor Author

wrt95 commented Oct 9, 2024

Blocked until this PR is merged

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (85c907d) to head (a8a34c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13745      +/-   ##
==========================================
+ Coverage   94.50%   94.51%   +0.01%     
==========================================
  Files        1620     1605      -15     
  Lines       21713    21536     -177     
  Branches     2569     2542      -27     
==========================================
- Hits        20519    20355     -164     
+ Misses        943      938       -5     
+ Partials      251      243       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95 wrt95 added team/studio-core skip-manual-testing PRs that do not need to be tested manually labels Oct 9, 2024
@wrt95 wrt95 marked this pull request as ready for review October 10, 2024 07:10
@framitdavid framitdavid merged commit f3053c6 into main Oct 10, 2024
9 checks passed
@framitdavid framitdavid deleted the refactor-delete-old-unused-altinn-header branch October 10, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants