Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add StudioTextResourcePicker component #13954

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Oct 30, 2024

Description

Added a simple component for choosing a text resource from a given list. It will be used by the text resource selector in the code list table.

The component:
image

Where it will be used:
image

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 30, 2024
@TomasEng TomasEng force-pushed the add-text-resource-picker branch from cd308a2 to 5b0410b Compare October 30, 2024 15:44
@TomasEng TomasEng added team/studio-domain1 skip-releasenotes Issues that do not make sense to list in our release notes skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually labels Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (7c1ce6d) to head (0cd3b74).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13954   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files        1691     1694    +3     
  Lines       22438    22450   +12     
  Branches     2630     2631    +1     
=======================================
+ Hits        21358    21370   +12     
  Misses        834      834           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng force-pushed the add-text-resource-picker branch from 5b0410b to 0cd3b74 Compare October 31, 2024 06:00
@TomasEng TomasEng marked this pull request as ready for review October 31, 2024 06:23
@ErlingHauan ErlingHauan self-assigned this Oct 31, 2024
@ErlingHauan ErlingHauan merged commit 79d7a4f into main Oct 31, 2024
11 checks passed
@ErlingHauan ErlingHauan deleted the add-text-resource-picker branch October 31, 2024 11:44
@ErlingHauan ErlingHauan removed their assignment Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants