-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable visualization of code list usage in library #14308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
frontend
labels
Dec 18, 2024
standeren
changed the title
feat: Visualize code list usage in library
feat: enable visualization of code list usage in library
Dec 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14308 +/- ##
=======================================
Coverage 95.53% 95.54%
=======================================
Files 1860 1862 +2
Lines 24099 24125 +26
Branches 2782 2785 +3
=======================================
+ Hits 23024 23050 +26
Misses 817 817
Partials 258 258 ☔ View full report in Codecov by Sentry. |
standeren
added
skip-releasenotes
Issues that do not make sense to list in our release notes
skip-documentation
Issues where updating documentation is not relevant
area/content-library
Area: Related to library for shared resources
team/studio-domain1
labels
Dec 19, 2024
ErlingHauan
reviewed
Dec 20, 2024
.../app-development/features/appContentLibrary/utils/convertOptionListsUsageToCodeListsUsage.ts
Outdated
Show resolved
Hide resolved
ErlingHauan
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
standeren
force-pushed
the
visualize-code-list-usage-in-library
branch
2 times, most recently
from
December 30, 2024 12:29
f7805bb
to
0b2b4bb
Compare
ErlingHauan
added
the
skip-manual-testing
PRs that do not need to be tested manually
label
Jan 3, 2025
standeren
force-pushed
the
visualize-code-list-usage-in-library
branch
from
January 3, 2025 14:45
0b2b4bb
to
a37a559
Compare
standeren
added
skip-manual-testing
PRs that do not need to be tested manually
and removed
skip-manual-testing
PRs that do not need to be tested manually
labels
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/content-library
Area: Related to library for shared resources
frontend
skip-documentation
Issues where updating documentation is not relevant
skip-manual-testing
PRs that do not need to be tested manually
skip-releasenotes
Issues that do not make sense to list in our release notes
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
team/studio-domain1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
This PR will allow us to deny deletion and code-list-id-editing if a code list is in use. However, it will not actually show where the code list is used, but the data to visualize it will be available in the library. Adding support to view where it is used will be another issue.
Verification
Documentation