Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable visualization of code list usage in library #14308

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Dec 18, 2024

Description

⚠️ Not implemented design in this PR, just an example of what data we have about the usage ⚠️
Skjermbilde 2024-12-19 kl  08 43 47

Related Issue(s)

This PR will allow us to deny deletion and code-list-id-editing if a code list is in use. However, it will not actually show where the code list is used, but the data to visualize it will be available in the library. Adding support to view where it is used will be another issue.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 18, 2024
@standeren standeren changed the title feat: Visualize code list usage in library feat: enable visualization of code list usage in library Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (1545c2d) to head (52bb156).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14308   +/-   ##
=======================================
  Coverage   95.53%   95.54%           
=======================================
  Files        1860     1862    +2     
  Lines       24099    24125   +26     
  Branches     2782     2785    +3     
=======================================
+ Hits        23024    23050   +26     
  Misses        817      817           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes skip-documentation Issues where updating documentation is not relevant area/content-library Area: Related to library for shared resources team/studio-domain1 labels Dec 19, 2024
@standeren standeren marked this pull request as ready for review December 19, 2024 07:51
@ErlingHauan ErlingHauan self-assigned this Dec 20, 2024
@ErlingHauan ErlingHauan assigned standeren and unassigned ErlingHauan Dec 20, 2024
@standeren standeren assigned ErlingHauan and unassigned standeren Dec 20, 2024
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ErlingHauan ErlingHauan assigned standeren and unassigned ErlingHauan Dec 20, 2024
@standeren standeren removed their assignment Dec 20, 2024
Base automatically changed from check-for-code-list-usage to main December 30, 2024 08:07
@standeren standeren force-pushed the visualize-code-list-usage-in-library branch 2 times, most recently from f7805bb to 0b2b4bb Compare December 30, 2024 12:29
@ErlingHauan ErlingHauan added the skip-manual-testing PRs that do not need to be tested manually label Jan 3, 2025
@standeren standeren force-pushed the visualize-code-list-usage-in-library branch from 0b2b4bb to a37a559 Compare January 3, 2025 14:45
@standeren standeren added skip-manual-testing PRs that do not need to be tested manually and removed skip-manual-testing PRs that do not need to be tested manually labels Jan 6, 2025
@standeren standeren merged commit 1e059fd into main Jan 6, 2025
11 checks passed
@standeren standeren deleted the visualize-code-list-usage-in-library branch January 6, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/content-library Area: Related to library for shared resources frontend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants