-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add text resource selector to code list editor #14354
feat: Add text resource selector to code list editor #14354
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14354 +/- ##
==========================================
+ Coverage 95.58% 95.65% +0.07%
==========================================
Files 1869 1871 +2
Lines 24237 24285 +48
Branches 2786 2788 +2
==========================================
+ Hits 23167 23231 +64
+ Misses 814 797 -17
- Partials 256 257 +1 ☔ View full report in Codecov by Sentry. |
...end/libs/studio-components/src/components/StudioCodelistEditor/StudioCodeListEditor.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 🚀
Btw, I tested it in storybook, and I noticed that when switching to search mode, the column gets larger. Might not happen when we use it in studio tho 🤷
...end/libs/studio-components/src/components/StudioCodelistEditor/StudioCodeListEditor.test.tsx
Show resolved
Hide resolved
...end/libs/studio-components/src/components/StudioCodelistEditor/StudioCodeListEditor.test.tsx
Outdated
Show resolved
Hide resolved
Yes, that's because they use the default width from The Design System. Not sure why it's different. Hopefully it will not be an issue in Studio because the table will have full width. |
I actually tested this as well, and it works as expected. So we can add the |
Description
This pull request adds
textResources
andonChangeTextResource
props toStudioCodeListEditor
, so that the user may select and edit text resources in the code list. The props are optional, so that iftextResources
are not set, the table appears like in the current solution (with regular input fields for the texts). I have not updated the usages ofStudioCodeListEditor
- I'll leave that to a future pull request. Consequently, this pull request does not change anything in Studio.Related Issue
Verification