Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorganize summary2 translation keys #14406

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Jan 13, 2025

Description

Reorganize translation keys for summary2 overrides so they are following the same pattern.
Also update some texts to match the new design

Related Issue(s)

This PR is stacked below: #14379

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • Localization

    • Updated Norwegian language translations for component summary and override settings.
    • Improved clarity of user interface texts related to component summaries.
    • Refined naming conventions for component summary configurations.
  • User Interface

    • Enhanced component summary display options with new configuration keys.
    • Standardized labels for display types and override settings for better user experience.

@Jondyr Jondyr added text/content used for issues that need som text improvements, often by ux frontend team/studio-domain2 labels Jan 13, 2025
Copy link
Contributor

coderabbitai bot commented Jan 13, 2025

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the Norwegian language JSON file and several components within the UX editor. Key changes involve the addition of new localization keys for component summaries, particularly regarding overrides and display types. Several existing keys related to component overrides have been removed, and the naming conventions for various UI elements have been updated to enhance clarity and consistency in the configuration and display of component properties.

Changes

File Change Summary
frontend/language/src/nb.json Added multiple new translation keys for component summary overrides, including options for choosing components, display types, and handling empty fields; removed several keys related to previous override management.
frontend/packages/ux-editor/.../Summary2Override.test.tsx Updated test case names and translation key references to align with new localization structure for summary overrides.
frontend/packages/ux-editor/.../Summary2Override.tsx Modified description text translation key to reflect new structure.
frontend/packages/ux-editor/.../Summary2OverrideDisplayType.tsx Updated label translation key for display type selection to the new naming convention.
frontend/packages/ux-editor/.../Summary2OverrideEntry.tsx Changed labels for component reference selector and compact checkbox to use new translation keys.
frontend/packages/ux-editor/.../hook/useCustomConfigType.ts Updated display type labels to use new, more specific translation keys related to summary context.

Possibly related PRs

Suggested labels

area/process, quality/testing, skip-releasenotes, skip-manual-testing, skip-documentation

Suggested reviewers

  • ErlingHauan
  • github-actions

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18c9d1c and f4f05b8.

📒 Files selected for processing (6)
  • frontend/language/src/nb.json (1 hunks)
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/Summary2Override.test.tsx (15 hunks)
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/Summary2Override.tsx (1 hunks)
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/Summary2OverrideDisplayType.tsx (1 hunks)
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/Summary2OverrideEntry.tsx (2 hunks)
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/hook/useCustomConfigType.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/Summary2Override.tsx
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/hook/useCustomConfigType.ts
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/Summary2OverrideEntry.tsx
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/Summary2OverrideDisplayType.tsx
  • frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/Summary2Override.test.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Build environment and run e2e test
  • GitHub Check: Testing
  • GitHub Check: CodeQL
🔇 Additional comments (1)
frontend/language/src/nb.json (1)

1447-1457: LGTM! The new translation keys follow a consistent pattern.

The new summary2 override translation keys are well-organized and follow a clear hierarchical structure (summary.override.*). The Norwegian translations are accurate and consistent.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jan 13, 2025
@Jondyr Jondyr changed the title Reorganize summary2 translation keys chore: reorganize summary2 translation keys Jan 13, 2025
@Jondyr Jondyr force-pushed the 13-01-new-summary2-translation-keys-and-reorganize branch from 69f8f24 to 18c9d1c Compare January 13, 2025 12:09
@Jondyr Jondyr force-pushed the 13-01-new-summary2-translation-keys-and-reorganize branch from 18c9d1c to f4f05b8 Compare January 14, 2025 13:00
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mlqn mlqn self-assigned this Jan 16, 2025
@mlqn mlqn added the skip-manual-testing PRs that do not need to be tested manually label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2 text/content used for issues that need som text improvements, often by ux
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants