-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove input- and viewProps from StudioToggleableTextfield
#14475
base: simplify-studio-toggleable-textfield-part-1
Are you sure you want to change the base?
fix: remove input- and viewProps from StudioToggleableTextfield
#14475
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
d10c617
to
b45f503
Compare
b45f503
to
7870a2a
Compare
…ify-studio-toggleable-textfield-part-2
16cc021
to
2f422c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## simplify-studio-toggleable-textfield-part-1 #14475 +/- ##
===============================================================================
- Coverage 95.69% 95.69% -0.01%
===============================================================================
Files 1887 1887
Lines 24554 24549 -5
Branches 2820 2817 -3
===============================================================================
- Hits 23497 23492 -5
Misses 798 798
Partials 259 259 ☔ View full report in Codecov by Sentry. |
Description
Remove inputProps and viewProps from
StudioToggleableTextfield
and pass necessary properties directly.Related Issue(s)
Verification