feat: added news about un-deploy #14663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughA new entry has been added to a JSON file under the news content component. The added item in the "news" array includes a specific date, an empty title field, and detailed content that informs users about the unpublishing process for apps along with associated documentation. Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
solution/studio/designer
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/app-development/features/overview/components/News/NewsContent/news.nb.json (1)
4-8: Add a title for the news entry.Other news entries in the file have descriptive titles. Consider adding a title that summarizes the un-deploy feature, similar to the format used in other entries.
{ "date": "2025-02-13", - "title": "", + "title": "Nå kan du avpublisere apper!", "content": "Vi har nå gjort det mulig å avpublisere apper. Du finner informasjon om hva du må tenke på før du avpubliserer og hvordan du gjør det i dokumentasjonen vår. Denne informasjonen er også tilgjengelig underveis i avpubliseringsprosessen." },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/app-development/features/overview/components/News/NewsContent/news.nb.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build environment and run e2e test
- GitHub Check: Testing
- GitHub Check: CodeQL
🔇 Additional comments (1)
frontend/app-development/features/overview/components/News/NewsContent/news.nb.json (1)
2-2:❓ Verification inconclusive
Verify JSON schema compliance.
The file references a schema file. Let's verify that the new entry complies with the schema.
🏁 Script executed:
#!/bin/bash # Description: Check if the schema file exists and validate the JSON against it fd --type f "news.schema.json" --exec cat {} \;Length of output: 974
Schema file verified – please confirm complete JSON compliance
- The
news.schema.jsonfile was located successfully, and its content confirms it defines a valid JSON schema for news items (requiringdate,title, andcontentwith proper formats).- The
$schemaproperty innews.nb.jsoncorrectly references this schema.- To fully validate the new entry, ensure that the JSON data in
news.nb.json(beyond the$schemareference) conforms to the schema’s requirements (e.g., properdateformat and inclusion of all required fields).
Ildest
reviewed
Feb 14, 2025
frontend/app-development/features/overview/components/News/NewsContent/news.nb.json
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14663 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 1914 1914
Lines 24961 24961
Branches 2858 2858
=======================================
Hits 23904 23904
Misses 799 799
Partials 258 258 ☔ View full report in Codecov by Sentry. |
framitdavid
added
the
skip-manual-testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Ildest
approved these changes
Feb 14, 2025
Ildest
reviewed
Feb 14, 2025
| { | ||
| "date": "2025-02-14", | ||
| "title": "", | ||
| "content": "Vi har nå gjort det mulig å avpublisere apper. Du får informasjon underveis, om hva du må tenke på før du avpubliserer. Du kan også lese om hvordan du gjør det i dokumentasjonen vår." |
There was a problem hiding this comment.
Er det et mellomrom for mye etter Vi?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added news about un-deploy
Related Issue(s)
Verification
Summary by CodeRabbit