Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ComponentSpecificContent into smaller parts #9510

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Split ComponentSpecificContent into smaller parts #9510

merged 1 commit into from
Jan 5, 2023

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Jan 4, 2023 •
edited
Loading

Description

  • Made separate components for each case in ComponentSpecificContent
  • Replaced some instances of getLanguageFromKey with useText

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

@github-actions github-actions bot added the area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. label Jan 4, 2023
@TomasEng TomasEng force-pushed the fix/split-component-specific-content branch 2 times, most recently from 40454c0 to c264a39 Compare January 4, 2023 14:05
@TomasEng TomasEng force-pushed the fix/split-component-specific-content branch from c264a39 to fc3b6c4 Compare January 4, 2023 14:17
@TomasEng TomasEng changed the title Split ComponentSpecificContent in smaller parts Split ComponentSpecificContent into smaller parts Jan 4, 2023
@TomasEng TomasEng marked this pull request as ready for review January 4, 2023 14:21
mijohansen
mijohansen approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@mijohansen mijohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

@TomasEng TomasEng merged commit a07fcb3 into master Jan 5, 2023
@TomasEng TomasEng deleted the fix/split-component-specific-content branch January 5, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mijohansen mijohansen mijohansen approved these changes

@nkylstad nkylstad Awaiting requested review from nkylstad

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasEng @mijohansen