Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview mode for checkboxes #9551

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Jan 10, 2023

Description

Added an "mvp" version of preview mode for checkboxes. I also added a button in the form builder to switch to preview mode for this component. We can change that later when we have implemented preview for all components and it becomes the default state, but in the meantime I think this is a good solution while we are transitioning to the new design. It allows users to test out the new view while the old one is still available.

This pull request does not include editing texts directly in the preview. I think we need to discuss with the designers exactly how this functionality should appear. It may be confusing for the users to see the same text editor appear twice (both in the middle section and in the right section).

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
    It works, but there are some issues in the design system's CheckboxGroup component. Labels should not listen to click events in presentation mode (since there are buttons inside the labels), and there is also some weird behaviour when selecting a checkbox.
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. labels Jan 10, 2023
@github-actions github-actions bot removed the area/dashboard Area: Related to the dashboard application label Jan 10, 2023
@TomasEng TomasEng marked this pull request as ready for review January 11, 2023 08:01
@TomasEng TomasEng merged commit 679d3c7 into master Jan 11, 2023
@TomasEng TomasEng deleted the feature/preview-in-form-builder branch January 11, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants