Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AddressComponent -> Address #1495

Closed
Tracked by #339
, #1660
...
olemartinorg opened this issue Sep 25, 2023 · 0 comments · Fixed by #1761
Closed
Tracked by #339
, #1660
...

Rename AddressComponent -> Address #1495

olemartinorg opened this issue Sep 25, 2023 · 0 comments · Fixed by #1761
Assignees
@olemartinorg @RonnyB71
Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change

Comments

@olemartinorg
Copy link
Contributor

No components, apart from AddressComponent has the Component suffix. We should remove this and just call it Address. When doing this, we should make sure to inform app developers when they mistakenly use the old component type.
@olemartinorg olemartinorg added the kind/breaking-change Issue/pull request containing a breaking change label Sep 25, 2023
@olemartinorg olemartinorg mentioned this issue Sep 25, 2023
Closed
@olemartinorg olemartinorg added the fe-v4 Issues to be solved before v4 goes gold label Sep 25, 2023
@RonnyB71 RonnyB71 mentioned this issue Nov 22, 2023
Closed
@olemartinorg olemartinorg self-assigned this Jan 30, 2024
@olemartinorg olemartinorg moved this to 👷 In Progress in Team Apps Jan 30, 2024
@olemartinorg olemartinorg mentioned this issue Jan 30, 2024
Merged
19 tasks
@olemartinorg olemartinorg moved this from 👷 In Progress to 🔎 Review in Team Apps Jan 30, 2024
@olemartinorg olemartinorg moved this from 🔎 Review to 🧪 Test in Team Apps Jan 31, 2024
@RonnyB71 RonnyB71 moved this from 🧪 Test to ✅ Done in Team Apps Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olemartinorg olemartinorg

@RonnyB71 RonnyB71

Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming AddressComponent -> Address + bugfixes, improvements Altinn/app-frontend-react
2 participants
@olemartinorg @RonnyB71