-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming AddressComponent -> Address + bugfixes, improvements #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out what StrictMode does, and when I saw that it purposely renders everything twice, it's obviously the cause of this problem. The profiler in the browser detects strict mode and fixes the numbers for us.
… (+ improving it! I think it was broken as-is)
…ternal state-keeping
…state to be a bit out of date, and caused expression lookups to fail on text resources when rows were deleted.
…onent, so that we don't send requests for every keystroke
…along with nullable option values
olemartinorg
added
the
kind/breaking-change
Issue/pull request containing a breaking change
label
Jan 30, 2024
olemartinorg
changed the title
Cleanup after rc1
Renaming AddressComponent -> Address + bugfixes, improvements
Jan 30, 2024
…ntaining this state in the context, but it's easy to just figure it out locally
…up-to-date when rewriting). Simplifying the AddButton component, extracting it out from RepeatingGroupContainer so that it doesn't trash React performance/shadow-DOM.
…and reducing re-renders, making extra sure you cannot add rows twice when using openByDefault
…ossible to add an endless amount of new (empty) rows for repeating groups
mikaelrss
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! 👏 I just have some nitpicky comments 😅
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 7 New issues |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StrictMode
in unit tests. The reason everything rendered twice in some unit tests was that I didn't read enough about what StrictMode does, and when I saw that it purposely renders everything twice, it's obviously the cause of this problem. The profiler in the browser detects strict mode and fixes the numbers for us.AddressComponent
->Address
Address
component (it mistakenly sent a request once for every letter the user typed). Added regression tests.null
values in option lists, as per Support number, boolean and null as AppOption values app-lib-dotnet#417. I also extended the data conversion function to allow for schemas withoneOf
andanyOf
, as it was useful in the unit-test I wrote.Related Issue(s)
AddressComponent
->Address
#1495Verification/QA
kind/*
label to this PR for proper release notes grouping